[accton/as5835-54x] Fix sfp related function like tx_disable#4763
Merged
jleveque merged 1 commit intosonic-net:masterfrom Jun 18, 2020
Merged
[accton/as5835-54x] Fix sfp related function like tx_disable#4763jleveque merged 1 commit intosonic-net:masterfrom
jleveque merged 1 commit intosonic-net:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuanyu_chen kuanyu_chen@edge-core.com
- Why I did it
The tx_disable function isn't work for the accton_ax5835-54x device.
- How I did it
Fix the incorrect path of the sfp node path inside the util file.
- How to verify it
Test with
"sudo accton_as5835_54x_util.py show"
"sudo accton_as5835_54x_util.py set sfp"
There should see correct value for module_present and module_tx_disable. And should able to set it.
- Description for the changelog
Fix sfp function of the accton_as5835_54x_util.py.